Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove klaos chain specifications and related predefined accounts #641

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Jun 28, 2024

PR Type

Enhancement


Description

  • Removed all references to klaos chain specifications from the command.rs file.
  • Simplified the conditional logic for loading chain specifications in the command.rs file.
  • Commented out klaos related predefined accounts in the predefined_accounts.rs file.
  • Removed the function that returns predefined accounts in the predefined_accounts.rs file.

Changes walkthrough 📝

Relevant files
Enhancement
command.rs
Remove `klaos` chain specifications from command module   

node/src/command.rs

  • Removed all references to klaos chain specifications.
  • Simplified conditional logic for loading chain specifications.
  • +1/-19   
    predefined_accounts.rs
    Comment out `klaos` predefined accounts and remove related function

    node/src/chain_spec/predefined_accounts.rs

  • Commented out klaos related predefined accounts.
  • Removed function returning predefined accounts.
  • +3/-16   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title removed klaos Remove klaos chain specifications and related predefined accounts Jun 28, 2024
    Copy link

    PR Description updated to latest commit (161fe42)

    @magecnion
    Copy link
    Contributor

    this also can be removed:

    laos/node/src/command.rs

    Lines 364 to 365 in b33aad7

    if runner.config().chain_spec.id().starts_with("klaos") {
    info!("-----------------------------------------------------------------");

    magecnion
    magecnion previously approved these changes Jun 28, 2024
    @asiniscalchi asiniscalchi linked an issue Jun 28, 2024 that may be closed by this pull request
    @asiniscalchi asiniscalchi merged commit 227dcfb into main Jun 28, 2024
    7 checks passed
    @asiniscalchi asiniscalchi deleted the feature/remove_klaos branch June 28, 2024 10:47
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Remove KLAOS
    3 participants