You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minimal pallet called benchmark (at pallets/benchmark/src) is required to benchmark precompiles whose code is not included in this repo (i.e. the vesting pallet in this PR)
The benchmark pallet is included in the LAOS config but it doesn't have any extrinsics, so it cannot be used by anyone in production
Precompile code can be found at pallets/benchmark/src/precompiles/vesting
…mpile
- Add e2e test to check main vesting functionality
- Some format changes
- Move endless script line from `package.json` to a separate file (`compile_contracts.sh`) so is more human understandable
- Add `extractRevertReason` function so tests are more precise
Performance Concern The weight functions in pallet_benchmark use hardcoded values for reads and writes, which might not accurately reflect the actual cost of operations on different storage items. Consider dynamically calculating these values based on the actual storage access patterns and data sizes involved.
Missing Error Handling The benchmarking code for vesting precompiles does not handle potential errors from external calls or internal logic failures. Ensure that all possible error paths are accounted for to avoid panics or undefined behavior during benchmarks.
Error Handling The VestingPrecompile module's methods do not consistently handle errors or revert transactions when conditions are not met. This could lead to unexpected state changes or failures. Review and ensure that all methods properly handle errors and revert as necessary.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#615
benchmark(atpallets/benchmark/src) is required to benchmark precompiles whose code is not included in this repo (i.e. the vesting pallet in this PR)pallets/benchmark/src/precompiles/vesting