Feature add Moonbeam's parachain staking precompile #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it compiles * test compiles * remove unneeded code * clippy issues * fix tests * merge * fix tests * include staking precompile in runtime * update staking precompile address * include readme * update readme * don't use default impl in mocks; resuse moonbeam address
…parachain-staking-precompile
magecnion
changed the title
…parachain-staking-precompile
asiniscalchi
previously approved these changes
Jul 24, 2024
luispdm
requested changes
Jul 24, 2024
asiniscalchi
approved these changes
Jul 26, 2024
asiniscalchi
deleted the
feature/add-moonbeam-parachain-staking-precompile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously merged #673 included the minimal changes necessary to accommodate the code from Moonbeam's precompile staking module so we can leverage its implementation:
try_dispatchfunction, as it doesn't exist in our version.rewards_account = Nonein the mock.The incremental changes included in the current PR are only the e2e tests.