Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to run E2E tests on PR review approval #693

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

magecnion
Copy link
Contributor

@magecnion magecnion commented Jul 26, 2024

PR Type

enhancement, configuration changes


Description

  • Added a condition in the GitHub Actions workflow to trigger E2E tests when a pull request review is submitted and approved.
  • Modified the E2E test job to run only if the review state is 'approved' or if manually triggered via workflow dispatch.

Changes walkthrough 📝

Relevant files
Configuration changes
e2e.yml
Add condition to run E2E tests on PR review approval         

.github/workflows/e2e.yml

  • Added condition to trigger E2E tests on pull request review
    submission.
  • Modified job to run only if the review state is 'approved' or
    triggered manually.
  • +3/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member

    /describe

    @github-actions github-actions bot changed the title Run e2e test is mandatory before merging to main Add condition to run E2E tests on PR review approval Jul 26, 2024
    Copy link

    PR Description updated to latest commit (7879c81)

    @asiniscalchi asiniscalchi changed the base branch from main to fix/e2e-test July 26, 2024 11:22
    @asiniscalchi asiniscalchi merged commit 46f303b into fix/e2e-test Jul 26, 2024
    7 of 8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/run-e2e-pre-main-merge branch July 26, 2024 11:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants