Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate and configure pallet_elections_phragmen in runtime #723

Merged
merged 37 commits into from
Sep 2, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Aug 9, 2024

PR Type

enhancement, configuration changes


Description

  • Integrated pallet_elections_phragmen into the runtime, allowing for election functionalities.
  • Added configuration for pallet_elections_phragmen, including parameters for candidacy bond, term duration, and voting lock period.
  • Updated benchmarks to include pallet_collective and pallet_elections_phragmen.
  • Modified Cargo.toml to include pallet-elections-phragmen in dependencies and feature sets.

Changes walkthrough 📝

Relevant files
Enhancement
benchmarks.rs
Add benchmarks for collective and elections pallets           

runtime/laos/src/benchmarks.rs

  • Added benchmarks for pallet_collective and pallet_elections_phragmen.
  • +2/-0     
    lib.rs
    Integrate elections pallet into runtime                                   

    runtime/laos/src/lib.rs

    • Integrated pallet_elections_phragmen into the runtime.
    +1/-0     
    Configuration changes
    election_phragmen.rs
    Add configuration for pallet_elections_phragmen                   

    runtime/laos/src/configs/election_phragmen.rs

  • Introduced configuration for pallet_elections_phragmen.
  • Defined parameters such as CandidacyBond, TermDuration, and
    VotingLockPeriod.
  • Implemented pallet_elections_phragmen::Config for Runtime.
  • +55/-0   
    mod.rs
    Include election_phragmen module in configurations             

    runtime/laos/src/configs/mod.rs

    • Added election_phragmen module to the configurations.
    +1/-0     
    Dependencies
    Cargo.toml
    Add elections pallet to Cargo.toml dependencies                   

    runtime/laos/Cargo.toml

  • Added pallet-elections-phragmen to dependencies.
  • Included pallet-elections-phragmen in various feature sets.
  • +4/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Feature/elections Integrate pallet_elections_phragmen into runtime and configurations Aug 9, 2024
    Copy link

    github-actions bot commented Aug 9, 2024

    PR Description updated to latest commit (af1d0b2)

    @asiniscalchi asiniscalchi linked an issue Aug 27, 2024 that may be closed by this pull request
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi marked this pull request as ready for review August 27, 2024 09:39
    @github-actions github-actions bot changed the title Integrate pallet_elections_phragmen into runtime and configurations Integrate and configure pallet_elections_phragmen in runtime Aug 27, 2024
    Copy link

    PR Description updated to latest commit (d4ac88f)

    @asiniscalchi asiniscalchi marked this pull request as draft August 27, 2024 09:44
    @asiniscalchi asiniscalchi self-assigned this Aug 28, 2024
    @asiniscalchi asiniscalchi marked this pull request as ready for review August 28, 2024 10:13
    runtime/laos/src/lib.rs Outdated Show resolved Hide resolved
    @magecnion
    Copy link
    Contributor

    This #751 should fix CI issues and add missing PalletId configuration param

    @luispdm luispdm merged commit 4136e17 into feature/add_treasury Sep 2, 2024
    8 checks passed
    @luispdm luispdm deleted the feature/elections branch September 2, 2024 10:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Integrate Elections for Committee Members
    3 participants