Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update treasury council majority requirements for decision making #757

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Update treasury council majority requirements for decision making #757

merged 2 commits into from
Sep 4, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Sep 4, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement

Description

  • Updated the ApproveOrigin and RejectOrigin logic in the treasury configuration to require a stricter council majority, changing from EnsureProportionAtLeast to EnsureProportionMoreThan.
  • This change affects how decisions are approved or rejected by the council, requiring more than half of the council members instead of at least half.

Changes walkthrough 📝

Relevant files
Enhancement
treasury.rs
Modify council majority requirements for treasury decisions

runtime/laos/src/configs/treasury.rs

  • Changed ApproveOrigin to require more than half of the council's
    approval.
  • Changed RejectOrigin to require more than half of the council's
    approval.
    		•  +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi marked this pull request as ready for review September 4, 2024 09:27
    @github-actions github-actions bot changed the title treasury on counci9l majority Update treasury council majority requirements for decision making Sep 4, 2024
    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Sep 4, 2024

    PR Description updated to latest commit (92a5934)

    @asiniscalchi asiniscalchi merged commit 2b31283 into main Sep 4, 2024
    9 checks passed
    @asiniscalchi asiniscalchi deleted the feature/treasure_uses_council_majority branch September 4, 2024 09:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @luispdm luispdm luispdm approved these changes

    @magecnion magecnion magecnion approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @asiniscalchi @magecnion @luispdm