Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust Toolchain to 1.77 and Code Enhancements #768

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update Rust Toolchain to 1.77 and Code Enhancements #768

merged 3 commits into from
Sep 9, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Sep 9, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement, bug fix

Description

  • Updated the Rust toolchain version to 1.77 in the rust-toolchain file.
  • Simplified the serde_json::to_value function call in laos.rs by removing an unnecessary reference.
  • Removed an unnecessary clippy allowance in the benchmarking file to clean up the code.

Changes walkthrough 📝

Relevant files
Enhancement
laos.rs
Simplified serde_json::to_value function call                       

node/src/chain_spec/laos.rs

  • Removed unnecessary reference in serde_json::to_value function call.
    		•  +1/-1     
    benchmarking.rs
    Cleaned up clippy allowance in benchmarking                           

    pallets/precompiles-benchmark/src/precompiles/vesting/benchmarking.rs

    • Removed unnecessary clippy allowance for multiple bound locations.
    		 +0/-1     
    Configuration changes
    rust-toolchain
    Updated Rust toolchain version to 1.77                                     

    rust-toolchain

    • Updated Rust toolchain version to 1.77.
    		 +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title using rust 1.77 Update Rust Toolchain to 1.77 and Code Enhancements Sep 9, 2024
    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Sep 9, 2024

    PR Description updated to latest commit (49bf08a)

    @asiniscalchi asiniscalchi merged commit a8a8b39 into release/v0.21 Sep 9, 2024
    7 checks passed
    @asiniscalchi asiniscalchi deleted the feature/using_1.77 branch September 9, 2024 11:25
    @magecnion magecnion mentioned this pull request Sep 9, 2024
    Closed
    asiniscalchi added a commit that referenced this pull request Sep 10, 2024
    @magecnion @asiniscalchi
    Update Weights and Execution Times for Multiple Pallets and Bump Runt…
    4e49bf8 
    …ime Version (#764)

* update version for v0.21.0

* update weights

* fix tests

* Update Rust Toolchain to 1.77 and Code Enhancements (#768)

* using rust 1.77

* fix compilation

* fix compilation

---------

Co-authored-by: Alessandro Siniscalchi <asiniscalchi@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @asiniscalchi