Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Council Membership and Simplify Technical Committee Configuration #783

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Remove Council Membership and Simplify Technical Committee Configuration #783

merged 3 commits into from
Sep 19, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Sep 19, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement

Description

  • Simplified the process for setting Technical Committee members by requiring only root origin, removing the council's ability to set members.
  • Removed the configuration and runtime construction related to Council membership, streamlining the governance structure.
  • Adjusted the runtime indices to reflect the removal of CouncilMembership.

Changes walkthrough 📝

Relevant files
Enhancement
collective.rs
Simplified Technical Committee membership origin to root only

runtime/laos/src/configs/collective.rs

  • Removed EitherOfDiverse trait import.
  • Changed SetMembersOrigin to use only EnsureRoot.
    		•  +3/-3     
    membership.rs
    Removed Council membership configuration                                 

    runtime/laos/src/configs/membership.rs

  • Removed CouncilMembership configuration.
  • Updated imports to remove Council.
    		•  +1/-15   
    lib.rs
    Updated runtime construction by removing CouncilMembership

    runtime/laos/src/lib.rs

  • Removed CouncilMembership from runtime construction.
  • Adjusted indices for TechnicalCommitteeMembership.
    		•  +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title removed the memebership for Council Remove Council Membership and Simplify Technical Committee Configuration Sep 19, 2024
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (b5fc79a)

    @asiniscalchi asiniscalchi marked this pull request as ready for review September 19, 2024 09:10
    @asiniscalchi asiniscalchi merged commit d48769b into feature/tech-committee-veto Sep 19, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/remove_council_memebrship branch September 19, 2024 09:37
    asiniscalchi added a commit that referenced this pull request Sep 19, 2024
    @luispdm @asiniscalchi
    Allow technical committee members to veto external proposals (#774)
    212d343 
    * add pallet membership (veto still not working)

* membership benchmarks

* `EnsureSignedBy` instead of `EnsureMember` to allow veto && unit test for veto

* Remove Council Membership and Simplify Technical Committee Configuration (#783)

* removed the memebership for Council

* council can't setMemebers of the Technical commeteed

* fix benchmark compilation

* added placeholder

---------

Co-authored-by: Alessandro Siniscalchi <asiniscalchi@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @luispdm luispdm luispdm approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @asiniscalchi @luispdm