Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pallet_bounties into runtime with configuration and dependencies #908

Merged
merged 16 commits into from
Dec 24, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Dec 10, 2024

PR Type

Enhancement


Description

  • Introduced pallet_bounties to the runtime configuration, enabling bounty-related functionality.
  • Added a new configuration file (bounties.rs) with parameters for bounties, such as deposit base, payout delay, and curator deposit.
  • Updated the treasury configuration to align with the new pallet_bounties.
  • Registered pallet_bounties in the runtime's construct_runtime macro.
  • Added pallet-bounties as a dependency in both the main and runtime-specific Cargo.toml files.

Changes walkthrough 📝

Relevant files
Enhancement
bounties.rs
Added configuration for `pallet_bounties` in runtime.       

runtime/laos/src/configs/bounties.rs

  • Added a new configuration file for the pallet_bounties.
  • Defined various parameters such as deposit base, payout delay, update
    period, and curator deposit.
  • Implemented the pallet_bounties::Config trait for the runtime.
  • +35/-0   
    mod.rs
    Integrated `bounties` module into runtime configuration. 

    runtime/laos/src/configs/mod.rs

    • Included the bounties module in the runtime configuration.
    +1/-0     
    treasury.rs
    Updated treasury configuration for compatibility with pallet_bounties.

    runtime/laos/src/configs/treasury.rs

  • Updated the SpendOrigin type to include a new EitherOf condition.
  • Adjusted treasury configuration to align with the new pallet_bounties.

  • +6/-11   
    lib.rs
    Registered `pallet_bounties` in runtime.                                 

    runtime/laos/src/lib.rs

    • Added pallet_bounties to the runtime's construct_runtime macro.
    +1/-0     
    Dependencies
    Cargo.toml
    Added `pallet-bounties` dependency to Cargo.toml.               

    Cargo.toml

    • Added pallet-bounties dependency to the project.
    +1/-0     
    Cargo.toml
    Included `pallet-bounties` in runtime workspace and features.

    runtime/laos/Cargo.toml

  • Added pallet-bounties to the workspace dependencies.
  • Included pallet-bounties in the standard and runtime-benchmarks
    features.
  • +4/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Feature/pallet bounties Integrate pallet_bounties into runtime with configuration and dependencies Dec 10, 2024
    Copy link

    PR Description updated to latest commit (d64153b)

    @asiniscalchi asiniscalchi linked an issue Dec 17, 2024 that may be closed by this pull request
    @tsenovilla tsenovilla merged commit 3c729b5 into main Dec 24, 2024
    10 checks passed
    @tsenovilla tsenovilla deleted the feature/pallet_bounties branch December 24, 2024 12:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Enable Treasury Spending (Bounty or otherwise)
    3 participants