Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weights and benchmarks for multiple pallets and increment runtime version. #923

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Dec 17, 2024

PR Type

enhancement


Description

  • Updated weights and benchmarks for multiple pallets (pallet_parachain_staking, pallet_democracy, pallet_collective, pallet_vesting, and pallet_precompiles_benchmark) to reflect the latest benchmarking results.
  • Reduced execution times and proof size estimates for various operations across the updated pallets.
  • Improved accuracy and standard error handling in weight calculations.
  • Incremented spec_version in runtime/laos/src/lib.rs to 2500 to reflect the new runtime version.
  • Updated benchmark CLI version and metadata for all modified weight files.

Changes walkthrough 📝

Relevant files
Enhancement
5 files
pallet_parachain_staking.rs
Update weights and benchmarks for `pallet_parachain_staking`.

runtime/laos/src/weights/pallet_parachain_staking.rs

  • Updated benchmark CLI version and metadata.
  • Adjusted weight calculations for various functions to reflect updated
    benchmarks.
  • Reduced execution times and proof size estimates for multiple
    operations.
  • Improved standard error handling in weight calculations.
  • +156/-154
    pallet_democracy.rs
    Update weights and benchmarks for `pallet_democracy`.       

    runtime/laos/src/weights/pallet_democracy.rs

  • Updated benchmark CLI version and metadata.
  • Adjusted weight calculations for democracy-related operations.
  • Reduced execution times and proof size estimates for voting and
    proposal functions.
  • Improved accuracy of weight estimation for various scenarios.
  • +81/-81 
    pallet_collective.rs
    Update weights and benchmarks for `pallet_collective`.     

    runtime/laos/src/weights/pallet_collective.rs

  • Updated benchmark CLI version and metadata.
  • Adjusted weight calculations for collective operations like voting and
    proposals.
  • Reduced execution times and proof size estimates for key functions.
  • Refined weight estimation for dynamic parameters.
  • +118/-122
    pallet_vesting.rs
    Update weights and benchmarks for `pallet_vesting`.           

    runtime/laos/src/weights/pallet_vesting.rs

  • Updated benchmark CLI version and metadata.
  • Adjusted weight calculations for vesting-related operations.
  • Reduced execution times and proof size estimates for vesting
    functions.
  • Improved standard error handling in weight calculations.
  • +64/-66 
    pallet_precompiles_benchmark.rs
    Update weights and benchmarks for `pallet_precompiles_benchmark`.

    runtime/laos/src/weights/pallet_precompiles_benchmark.rs

  • Updated benchmark CLI version and metadata.
  • Adjusted weight calculations for precompile vesting operations.
  • Reduced execution times and proof size estimates for precompile
    functions.
  • Improved weight estimation for dynamic parameters.
  • +13/-13 
    Configuration changes
    1 files
    lib.rs
    Update runtime version to 2500.                                                   

    runtime/laos/src/lib.rs

  • Incremented spec_version to 2500 to reflect the new runtime version.
  • +1/-1     
    Additional files (token-limit)
    21 files
    pallet_scheduler.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_scheduler.rs

    ...

    +95/-95 
    pallet_membership.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_membership.rs

    ...

    +117/-113
    pallet_elections_phragmen.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_elections_phragmen.rs

    ...

    +54/-54 
    pallet_preimage.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_preimage.rs

    ...

    +36/-36 
    pallet_proxy.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_proxy.rs

    ...

    +50/-50 
    pallet_asset_metadata_extender.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_asset_metadata_extender.rs

    ...

    +46/-46 
    pallet_laos_evolution.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_laos_evolution.rs

    ...

    +31/-31 
    cumulus_pallet_xcmp_queue.rs
    ...                                                                                                           

    runtime/laos/src/weights/cumulus_pallet_xcmp_queue.rs

    ...

    +31/-31 
    pallet_multisig.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_multisig.rs

    ...

    +35/-35 
    pallet_message_queue.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_message_queue.rs

    ...

    +22/-22 
    pallet_treasury.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_treasury.rs

    ...

    +20/-19 
    pallet_sudo.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_sudo.rs

    ...

    +14/-14 
    pallet_utility.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_utility.rs

    ...

    +18/-18 
    pallet_session.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_session.rs

    ...

    +6/-6     
    pallet_timestamp.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_timestamp.rs

    ...

    +6/-6     
    cumulus_pallet_parachain_system.rs
    ...                                                                                                           

    runtime/laos/src/weights/cumulus_pallet_parachain_system.rs

    ...

    +6/-6     
    democracy.rs
    ...                                                                                                           

    runtime/laos/src/configs/democracy.rs

    ...

    +6/-4     
    pallet_treasury_funding.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_treasury_funding.rs

    ...

    +4/-4     
    pallet_evm.rs
    ...                                                                                                           

    runtime/laos/src/weights/pallet_evm.rs

    ...

    +4/-4     
    constants.ts
    ...                                                                                                           

    e2e-tests/utils/constants.ts

    ...

    +1/-1     
    Cargo.toml
    ...                                                                                                           

    Cargo.toml

    ...

    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi asiniscalchi force-pushed the feature/prepare_release_v_0_25_00 branch from 8d4d38f to 8567658 Compare December 17, 2024 12:20
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title update to version v0.25.0 Update weights and benchmarks for multiple pallets and increment runtime version. Dec 17, 2024
    Copy link

    PR Description updated to latest commit (e33dd93)

    @asiniscalchi asiniscalchi marked this pull request as ready for review December 17, 2024 16:34
    @magecnion magecnion merged commit 2bfc5ba into main Dec 18, 2024
    10 checks passed
    @magecnion magecnion deleted the feature/prepare_release_v_0_25_00 branch December 18, 2024 08:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants