Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Monaco Editor #239

Merged
merged 10 commits into from
Mar 11, 2023
Merged

Add support for Monaco Editor #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4677df3
Add support for Monaco Editor
ryan6416 Jan 23, 2023
70c46f8
add throttle & check if it's user change
ryan6416 Jan 23, 2023
a2f11ec
address pr feedback
ryan6416 Jan 24, 2023
c15b818
Fix selectors
fregante Jan 27, 2023
e1a1ffb
Use `getModel`
fregante Jan 27, 2023
1bd6049
Use class instead of data-uri attribute
fregante Jan 27, 2023
ffafdea
Fix syntax error
fregante Jan 27, 2023
1c4ad9d
Lint
fregante Jan 27, 2023
4587783
Merge remote-tracking branch 'origin/main' into pr/239
fregante Jan 27, 2023
c99bd98
Fix browser -> editor direction
fregante Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/ghost-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ class AdvancedTextWrapper {
}

function wrapField(field) {
const monaco = field.closest('.monaco-editor');
if (monaco) {
const visualElement = monaco.querySelector('.monaco-editor-background');
return new AdvancedTextWrapper(monaco, visualElement);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now

Screenshot 3

}

if (field.classList.contains('ace_text-input')) {
const ace = field.parentNode;
const visualElement = ace.querySelector('.ace_scroller');
Expand Down
20 changes: 20 additions & 0 deletions source/unsafe-messenger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ export default function unsafeMessenger() {
function listener({target}) {
if (target.CodeMirror) {
codeMirror(target);
} else if (target.classList.contains('monaco-editor')) {
monacoEditor(target);
} else {
ace(target);
}
Expand Down Expand Up @@ -73,6 +75,24 @@ export default function unsafeMessenger() {
editor.blur();
});
}

function monacoEditor(target) {
const editor = globalThis.monaco.editor.getModel(target.dataset.uri);
sendBack(target, editor.getValue());

editor.onDidChangeContent(throttle(50, event => {
if (!event.isFlush) { // Flush === setValue
sendBack(target, editor.getValue());
}
}));

target.addEventListener('gt:transfer', () => {
editor.setValue(target.getAttribute('gt-value'));
});
target.addEventListener('gt:blur', () => {
target.ownerDocument.activeElement.blur();
});
}
}

// eslint-disable-next-line no-unused-expressions
Expand Down