Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cache.set(x, undefined) to delete the cached item #26

Merged
merged 9 commits into from
Nov 22, 2020
Merged

Allow cache.set(x, undefined) to delete the cached item #26

merged 9 commits into from
Nov 22, 2020

Commits on Sep 23, 2020

  1. Allow cache.set(x, undefined) to delete the cached item (fix #25)

    @cheap-glitch
    cheap-glitch committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5e03fc2 View commit details
    Browse the repository at this point in the history

  2. Update test to match new behaviour of cache.set(x, undefined)

    @cheap-glitch
    cheap-glitch committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    158348b View commit details
    Browse the repository at this point in the history

  3. Return after deleting cached value 

    Co-authored-by: Federico <me@fregante.com>
    @cheap-glitch @fregante
    cheap-glitch and fregante authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6daeac9 View commit details
    Browse the repository at this point in the history

  4. Fix types ?

    @fregante
    fregante authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6f2a6a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Fix merge conflict

    @cheap-glitch
    cheap-glitch committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    ac2e01b View commit details
    Browse the repository at this point in the history

  2. Throw an error when set() is called without a value

    @cheap-glitch
    cheap-glitch committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    8a8903f View commit details
    Browse the repository at this point in the history

  3. Improve error message 

    Co-authored-by: Federico <me@fregante.com>
    @cheap-glitch @fregante
    cheap-glitch and fregante authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    82d2c82 View commit details
    Browse the repository at this point in the history

  4. Fix expected message in test

    @cheap-glitch
    cheap-glitch committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    64baf1f View commit details
    Browse the repository at this point in the history

  5. Use if/else since now they both return a value

    @fregante
    fregante authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    fc53de5 View commit details
    Browse the repository at this point in the history