Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_falter: add bool that indicates small flash #34

Closed
wants to merge 1 commit into from

Conversation

PolynomialDivision
Copy link
Contributor

Check if the device is a small flash device.

Check if the device is a small flash device.
@pmelange
Copy link
Contributor

Can you be a bit more descriptive in the need for a variable which is not used again? Is some magic happening somewhere? If so, can you describe that magic in the commit message?

@Akira25
Copy link
Member

Akira25 commented Jan 2, 2021

@pmelange AFAICT this is a variable that gets evaluated by imagebuilder itself. If I got @PolynomialDivision right, we could use a light-package-list if that switch is set. The logic for that is not implemented yet.

@pmelange
Copy link
Contributor

pmelange commented Jan 4, 2021

Then, when the logic is ready, let's add it. :)

@pmelange
Copy link
Contributor

pmelange commented Sep 4, 2021

Does anyone want this feature? What would we change for small flash devices?

@Akira25
Copy link
Member

Akira25 commented Sep 5, 2021

I'd really like to have this feature. for 8MB-Devices I would drop some tools in the notunnel and tunneldigger images. Most regular users won't need packages like tmux, vnstat and so on.

I don't know for sure, how to implement this feature though.

@PolynomialDivision do you know how to handle this?

@Akira25
Copy link
Member

Akira25 commented Mar 26, 2022

@PolynomialDivision I've build some 8MB-Flash-Devices now using the imagebuilder none of them had that option CONFIG_SMALL_FLASH in their .config. Is that only for 4MB-Devices? Anyway we should find another way to detect 8MB-Devices then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants