falter-berlin-autoupdate: Add error prompt for board-json #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
approved these changes
May 7, 2023
Noki
requested changes
May 7, 2023
Akira25
force-pushed
the
add_error_prompt_autoupdate
branch
from
ede7457
to
36276fe
Compare
Akira25
force-pushed
the
add_error_prompt_autoupdate
branch
2 times, most recently
from
b3a0116
to
1c207b8
Compare
When there was no board-json on the firmware selector autoupdate responded with a too generic error message. Thus we get more specific here. Fixes #376 Signed-off-by: Martin Hübner <martin.hubner@web.de>
Shellcheck found some minor issues left, that were fixed with this commit. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Add a notice that autoupdate is licensed under GPL. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
force-pushed
the
add_error_prompt_autoupdate
branch
from
1c207b8
to
c3e52c3
Compare
|
Merging due to approval. |
|
cherry-picked -x to 22.03 and 23.05 branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was no board-json on the firmware selector autoupdate responded with a too generic error message. Thus we get more specific here.
Fixes #376
Please cherry-pick -x to 22.03 and 21.02