Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress bandwidth shaping with tunneldigger #1460

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Support ingress bandwidth shaping with tunneldigger #1460

merged 1 commit into from
Jul 25, 2018

Conversation

kaechele
Copy link
Contributor

@kaechele kaechele commented Jul 9, 2018

Fix for #1447

Signed-off-by: Felix Kaechele felix@kaechele.ca

@rotanid rotanid added the 0. type: enhancement The changeset is an enhancement label Jul 9, 2018
Signed-off-by: Felix Kaechele <felix@kaechele.ca>
@rotanid
Copy link
Member

rotanid commented Jul 25, 2018

@kaechele have you tested this with firmwares with and without tunneldigger?

@kaechele
Copy link
Contributor Author

Only tested on firmware with tunneldigger so far.
As im moving to the US right now I unfortunately don't have the time to do further testing in the next 3-4 weeks.

@rotanid
Copy link
Member

rotanid commented Jul 25, 2018

ok, but as there are the has_tunneldigger checks i don't see any problem for non-tunneldigger

@rotanid rotanid merged commit d87c4b5 into freifunk-gluon:master Jul 25, 2018
@lrnzo
Copy link
Contributor

lrnzo commented Mar 13, 2019

Hello,

I do not understand two things:

  1. why is there no uci:set('tunneldigger', 'mesh_vpn', 'limit_bw_up', site.mesh_vpn.bandwidth_limit.egress()) in package/gluon-mesh-vpn-core/luasrc/lib/gluon/upgrade/500-mesh-vpn?
  2. why do i have the impression that uci:get("tunneldigger", "mesh_vpn", "limit_bw_down") from line 52 of package/gluon-config-mode-mesh-vpn/luasrc/lib/gluon/config-mode/wizard/0300-mesh-vpn.lua fails? When i check the box "limit bandwitdth" on a newly installed l2tp-firmware (gluon v2018.2.x) it looks like so:
    Bildschirmfoto_2019-03-13_21-25-26

In the site.conf i have this:

bandwidth_limit = {
	enabled = false,
	ingress = 100,
	egress = 200,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: enhancement The changeset is an enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants