Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neighbour/offloader capabilities #22

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add neighbour/offloader capabilities #22

merged 1 commit into from
Jan 10, 2022

Conversation

peterbaumert
Copy link
Contributor

No description provided.

@awlx
Copy link
Member

awlx commented Jan 10, 2022

Please add docstrings to the dataclasses. :)

Also I think people get confused with the dict directly in the yaml shouldn't we serialise a dict like this:

offloader_mac:
- site1_name: mac
- site2_name : mac

@GoliathLabs
Copy link
Member

GoliathLabs commented Jan 10, 2022

You might want to squash your git commits (https://www.git-tower.com/learn/git/faq/git-squash)

First try

one static offloader for all sites

python3.7....

fix stuff

site desc not name

README

better format

damn tab
@peterbaumert
Copy link
Contributor Author

You might want to squash your git commits (https://www.git-tower.com/learn/git/faq/git-squash)

I did, thanks for the hint. Git noob here :D

@awlx awlx merged commit 91d58fe into freifunkMUC:main Jan 10, 2022
@awlx
Copy link
Member

awlx commented Jan 10, 2022

I can just squash them during merge ;).

@GoliathLabs
Copy link
Member

Nonetheless, it is a good practice, as some other projects are quite picky about this (e.g. OpenWrt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants