Some fixes for the loadbalancing changes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
added
bug
DasSkelett
force-pushed
the
loadbalancing-fixes
branch
2 times, most recently
from
6f1f70f
to
169e076
Compare
- [worker] Use pyroute2.IPRoute instead of .NDB to get wg link address, as NDB() takes 20 seconds to instantiate - [worker] Fix get_connected_peers_count() for peers without handshake time - [broker] Use peer count sum from all domains to correctly calculate diff to expected peers in get_best_worker() - [broker] Don't update worker status on MQTT messages if it hasn't actually changed
DasSkelett
force-pushed
the
loadbalancing-fixes
branch
from
937bd02
to
908efa4
Compare
GoliathLabs
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugs I noticed while trying out #87 on a gateway: