Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run go build in docker (cd&rollout) #1022

Merged
merged 29 commits into from
Oct 23, 2023

Conversation

sven-urbanski-freiheit-com
Copy link
Contributor

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com commented Oct 17, 2023

  • Removes the "backend" docker container (it was redundant).
  • cd & rollout services now actually build go code in docker. Before, the binary was build on the host, and then only copied into the docker image.

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com marked this pull request as ready for review October 19, 2023 16:27
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com requested a review from a team as a code owner October 19, 2023 16:27
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com changed the title WIP go in docker Actually run go build in docker Oct 19, 2023
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com changed the title Actually run go build in docker Actually run go build in docker (cd&rollout) Oct 20, 2023
@hannesg
Copy link
Member

hannesg commented Oct 20, 2023

I think the name swissknife is really bad. I sounds like "does everything for that we don't have a name". Why not keep builder?

Makefile.variables Outdated Show resolved Hide resolved
Makefile.variables Outdated Show resolved Hide resolved
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com merged commit 31659ac into main Oct 23, 2023
13 checks passed
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com deleted the su-go-in-docker branch October 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants