-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually run go build
in docker (cd&rollout)
#1022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sven-urbanski-freiheit-com
commented
Oct 17, 2023
•
edited
Loading
edited
- Removes the "backend" docker container (it was redundant).
- cd & rollout services now actually build go code in docker. Before, the binary was build on the host, and then only copied into the docker image.
sven-urbanski-freiheit-com
force-pushed
the
su-go-in-docker
branch
from
October 17, 2023 13:55
b806a24
to
fb8100d
Compare
sven-urbanski-freiheit-com
force-pushed
the
su-go-in-docker
branch
from
October 18, 2023 09:27
feb9dee
to
197bc22
Compare
sven-urbanski-freiheit-com
force-pushed
the
su-go-in-docker
branch
from
October 19, 2023 16:27
10725fb
to
a235338
Compare
sven-urbanski-freiheit-com
changed the title
WIP go in docker
Actually run Oct 19, 2023
go build
in docker
sven-urbanski-freiheit-com
changed the title
Actually run
Actually run Oct 20, 2023
go build
in dockergo build
in docker (cd&rollout)
leandro-freiheit
approved these changes
Oct 20, 2023
I think the name |
hannesg
reviewed
Oct 20, 2023
… fix cd-service dockerfile
sven-urbanski-freiheit-com
force-pushed
the
su-go-in-docker
branch
from
October 23, 2023 09:05
ea20765
to
050829e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.