Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/lestrrat-go/jwx/v2 to v2.0.15 #1036

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 20, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/lestrrat-go/jwx/v2 require patch v2.0.14 -> v2.0.15

Release Notes

lestrrat-go/jwx (github.com/lestrrat-go/jwx/v2)

v2.0.15

Compare Source

v2.0.15 19 20 Oct 2023
[Bug fixes]
  * [jws] jws.Sign() now properly check for valid algorithm / key type pair when
    the key implements crypto.Signer. This was caused by the fact that when 
    jws.WithKey() accepted keys that implemented crypto.Signer, there really
    is no way to robustly check what algorithm the crypto.Signer implements.

    The code has now been modified to check for KNOWN key types, i.e. those
    that are defined in Go standard library, and those that are defined in
    this library. For example, now calling jws.Sign() with jws.WithKey(jwa.RS256, ecdsaKey)
    where ecdsaKey is either an instance of *ecdsa.PrivateKey or jwk.ECDSAPrivateKey
    will produce an error.

    However, if you use a separate library that wraps some KMS library which implements
    crypto.Signer, this same check will not be performed due to the fact that
    it is an unknown library to us. And there's no way to query a crypto.Signer
    for its algorithm family.

Configuration

📅 Schedule: Branch creation - "before 10am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 20, 2023 01:57
@renovate renovate bot added the renovate label Oct 20, 2023
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com merged commit 0769511 into main Oct 20, 2023
12 checks passed
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com deleted the renovate/git.luolix.top-lestrrat-go-jwx-v2-2.x branch October 20, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant