Fix server_test in frontend-service #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesg
approved these changes
Oct 24, 2023
The function runServer used the Fatal function of the zap logger. This has really unfortunate results in tests: You cannot see any details, except the name of the test and that it failed Instead we should always log with "Error" and then return the error (or only return the error)
sven-urbanski-freiheit-com
force-pushed
the
su-fix-frontend-server-test-2
branch
from
98fe92b
to
a72e204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function runServer used the Fatal function of the zap logger. This has really unfortunate results in tests: You cannot see any details, except the name of the test and that it failed Instead we should always log with "Error" and then return the error (or only return the error).