Fix frontend service docker image #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-nour-fdc
approved these changes
Nov 1, 2023
The docker image of the frontend-service returned html (http code 200), that just renders an empty page. This page displayed "404", but it was not the actual http status code. The issue was introduced in #1042 This adds the "build" directory to the frontend docker image.
sven-urbanski-freiheit-com
force-pushed
the
su-fix-frontend-docker
branch
from
a2abc2b to
4858e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image of the frontend-service returned html (http code 200), that just renders an empty page. This page displayed "404", but it was not the actual http status code.
The issue was introduced in #1042
This adds the "build" directory to the frontend docker image.