SRX-FZ6M63/#1043: fix colors for environments #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we really want that? Note that if we change this to all environments between UPSTREAM and PROD are PRE_PROD, then OTHER will almost never appear (AFAICS only with broken configs containing loops). Clarified with @sven-urbanski-freiheit-com: We want no all environments between UPSTREAM and PROD to be marked as PRE_PROD, only the last one. The rest shall be OTHER. |
bjoern-michaelsen-freiheit
force-pushed
the
bm/gh#1043
branch
3 times, most recently
from
59dc7e4 to
ae1c716
Compare
- use the following rules to determine the "priority" of an environment:
* UPSTREAM is an environment that has no upstream environment of it
own
* PROD is an environment that no environment names as its upstream
* PRE_PROD is an evironment that is the upstream of a PROD environment
* any remaining environment is marked OTHER
* PROD takes precedence over UPSTREAM and PRE_PROD
* PRE_PROD takes precendence over UPSTREAM
- the precendence rules are kept for backwards compatibility:
* note they imply that PRE_PROD can only exist if there are at least
two daisy chained environments
* note they imply that an UPSTREAM environment can only exist, if
there are at least three daisy chained environments
* => consider breaking compatibility making UPSTREAM take precedence
over PRE_PROD
- note this means if there are n > 1 environments between UPSTREAM and
PROD, only the last environment before PROD will be marked PRE_PROD
- modify existing tests (slightly breaking backwards compatibility):
* if the chain of environments contains loops, all environments are
marked OTHER. This is likely for the better.
* multiple enviroments with no upstream will all get marked the same
way as PROD.
This PR intends to fix #1043 .
bjoern-michaelsen-freiheit
force-pushed
the
bm/gh#1043
branch
from
46a1cf1 to
6ac74c1
Compare
sven-urbanski-freiheit-com
approved these changes
Nov 7, 2023
leandro-freiheit
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marked OTHER. This is likely for the better.
way as PROD.
then they are marked as Priority "UPSTREAM" and "PROD"
This PR intends to fix #1043 .