Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in rollout-service metrics #1127

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix race condition in rollout-service metrics #1127

merged 1 commit into from
Nov 13, 2023

Conversation

hannesg
Copy link
Member

@hannesg hannesg commented Nov 13, 2023

The rollout service processes metrics async. That means, if the check happens too fast we get the wrong result. This MR adds a done function that syncs the testing with the processing.

@hannesg hannesg requested a review from a team as a code owner November 13, 2023 10:31
@hannesg hannesg added the patch label Nov 13, 2023
@hannesg hannesg enabled auto-merge (squash) November 13, 2023 11:15
@hannesg hannesg merged commit 915c19b into main Nov 13, 2023
9 of 10 checks passed
@hannesg hannesg deleted the fix-race-condition-rollout-test branch November 13, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com sven-urbanski-freiheit-com approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesg @sven-urbanski-freiheit-com