Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return from endpoint GetProductSummary() for empty Summary #1199

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix return from endpoint GetProductSummary() for empty Summary #1199

merged 1 commit into from
Dec 7, 2023

Conversation

gsandok
Copy link
Collaborator

@gsandok gsandok commented Dec 6, 2023 •
edited by sven-urbanski-freiheit-com
Loading

  • fixes error Internal desc = grpc: error while marshaling: proto: Marshal called with nil
  • Frontend no longer stuck on loading when there are no apps associated with environment based on a git tag
  • also fix prettier warning within Links
Screenshot 2023-12-06 at 17 34 58

@gsandok
Fix return from endpoint GetProductSummary() for empty Summary
27aa391 
- fixes error Internal desc = grpc: error while marshaling: proto: Marshal called with nil
- also fix prettier warning within Links
@gsandok gsandok requested a review from a team as a code owner December 6, 2023 16:38
@gsandok gsandok added the minor label Dec 6, 2023
@gsandok gsandok merged commit 7e50c02 into main Dec 7, 2023
10 of 11 checks passed
@gsandok gsandok deleted the gs/fix_empty_return_product_summary branch December 7, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com sven-urbanski-freiheit-com approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsandok @sven-urbanski-freiheit-com