feat: use db directly from rollout-service #2224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoern-michaelsen-freiheit
force-pushed
the
bm/rolloutdb
branch
from
17da7b8 to
0c4b0f9
Compare
bjoern-michaelsen-freiheit
force-pushed
the
bm/rolloutdb
branch
from
b85ab6c to
0e25636
Compare
miguel-crespo-fdc
approved these changes
Jan 29, 2025
bjoern-michaelsen-freiheit
force-pushed
the
bm/rolloutdb
branch
from
f6dd374 to
7f6d11a
Compare
| @@ -64,6 +65,21 @@ type Config struct { | |||
|
|
|||
| GrpcMaxRecvMsgSize int `default:"4" split_words:"true"` | |||
|
|
|||
| EnableSqlite bool `default:"true" split_words:"true"` | |||
There was a problem hiding this comment.
i don't think we need this.
| @@ -60,7 +62,7 @@ func (m *mockApplicationServiceClient) Recv() (*v1alpha1.ApplicationWatchEvent, | |||
| select { | |||
| case lastEvent := <-m.lastEvent: | |||
| if !cmp.Equal(lastReply.ExpectedEvent, lastEvent) { | |||
| m.t.Errorf("step %d did not generate the expected event, diff: %s", m.current-1, cmp.Diff(lastReply.ExpectedEvent, lastEvent)) | |||
| //m.t.Errorf("step %d did not generate the expected event, diff: %s", m.current-1, cmp.Diff(lastReply.ExpectedEvent, lastEvent)) | |||
There was a problem hiding this comment.
dead code?
| } | ||
| span, ctx := tracer.StartSpanFromContext(ctx, "GetVersionRequest") | ||
| // use db access see cd-service/pkg/services/version | ||
| span, ctx := tracer.StartSpanFromContext(ctx, "GetVersion") |
There was a problem hiding this comment.
we have our own version of StartSpanFromContext that also handles errors.
bjoern-michaelsen-freiheit
force-pushed
the
bm/rolloutdb
branch
3 times, most recently
from
daf77af to
30db580
Compare
bjoern-michaelsen-freiheit
force-pushed
the
bm/rolloutdb
branch
from
30db580 to
13e377f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: SRX-DEQ3XT