Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRX-GUPKQB - argocd baseurl argument #234

Merged
merged 6 commits into from
Jul 15, 2022
Merged

SRX-GUPKQB - argocd baseurl argument #234

merged 6 commits into from
Jul 15, 2022

Conversation

medo-freiheit
Copy link
Contributor

  • clean up unused Argocd arguments
  • add Argocd baseurl argument
  • create getConfig rpc

@mouhsen-ibrahim
Copy link
Contributor

@medo-freiheit please remove installing the ArgoCD client in Dockerfile

hannesg
hannesg reviewed Jul 8, 2022
View reviewed changes
pkg/api/api.proto Outdated Show resolved Hide resolved
@medo-freiheit
Copy link
Contributor Author

@medo-freiheit please remove installing the ArgoCD client in Dockerfile

@mouhsen-ibrahim @hannesg I think we still need it for syncing, right? here

@medo-freiheit medo-freiheit force-pushed the MA/add-link-to-argocd branch from 00a6c13 to d17df78 Compare July 15, 2022 08:39
@sven-urbanski-freiheit-com
Copy link
Contributor

@medo-freiheit please remove installing the ArgoCD client in Dockerfile

@mouhsen-ibrahim @hannesg I think we still need it for syncing, right? here

We don't use the sync endpoint in any team, please remove it. @medo-freiheit

@medo-freiheit medo-freiheit force-pushed the MA/add-link-to-argocd branch from 92faac4 to 907ba84 Compare July 15, 2022 13:56
@medo-freiheit medo-freiheit merged commit 42e4ba4 into main Jul 15, 2022
@medo-freiheit medo-freiheit deleted the MA/add-link-to-argocd branch July 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesg hannesg hannesg left review comments

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com sven-urbanski-freiheit-com approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medo-freiheit @mouhsen-ibrahim @sven-urbanski-freiheit-com @hannesg