Temporarily going back to use a persistant volume #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we still have a cache, and that cache only works when the data is stored beyond pod restarts. In the future we will remove the cache and go back to emptydir, but for now, we need the cache working. This is almost an exact revert of commit fc057869dc4656cc59e5db195f1cb4879c720add.
mouhsen-ibrahim
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we still have a cache, and that cache only works when the data is stored beyond pod restarts.
In the future we will remove the cache and go back to emptydir, but for now, we need the cache working.
This does not fix the high memory usage, but it will improve startup times after the cache is filled once.
This is almost an exact revert of commit fc057869dc4656cc59e5db195f1cb4879c720add.