Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRX-EN3BAY Add indicator on the active Page in the left side bar #311

Merged
merged 3 commits into from
Aug 23, 2022
Merged

SRX-EN3BAY Add indicator on the active Page in the left side bar #311

merged 3 commits into from
Aug 23, 2022

Conversation

leandro-freiheit
Copy link
Contributor

No description provided.

@leandro-freiheit
Copy link
Contributor Author

leandro-freiheit commented Aug 23, 2022 •
edited
Loading

I noticed that in the navListItem.tsx when pathname.startsWith is used, the result will always return false.

This happens because useLocation() returns the path /v2/...

@leandro-freiheit leandro-freiheit merged commit 6e4e482 into main Aug 23, 2022
@leandro-freiheit leandro-freiheit deleted the LS/insert-page-indicator branch August 23, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tameremad tameremad tameremad left review comments

@medo-freiheit medo-freiheit medo-freiheit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandro-freiheit @tameremad @medo-freiheit