Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage design. #496

Merged
merged 20 commits into from
Feb 23, 2023
Merged

Update homepage design. #496

merged 20 commits into from
Feb 23, 2023

Conversation

tameremad
Copy link
Contributor

Starting with the new homepage design:

  • Adding a tooltip component from mdc.
  • styling it with corners and borders and etc...
  • change the environment colors
  • display short environment tags on release cards
  • fix bug with release cards shadows
  • make release cards smaller and shift around where the details are displayed

SRX-OD9V6S

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

@tameremad
Copy link
Contributor Author

tameremad commented Feb 22, 2023

There was a bug in ReleaseDialog: The time gets displayed in UTC timezone at all times.

e.g. I create a lock at 12:15
when it shows up on the ui it just says 11:15. 

The actual stored date is correct but it's displayed incorrectly. (because toISOString doesn't account for the local timezone, it's always constant for a given date)

{'Release date ' +
release?.createdAt.toISOString().split('T')[0] +
' ' +
release?.createdAt.toISOString().split('T')[1].split(':')[0] +
':' +
release?.createdAt.toISOString().split('T')[1].split(':')[1]}
</div>

The Fix: I created a getFormattedReleaseDate function and used it for the Tooltip and the Release Dialog.

After fixing this issue, I updated the snapshot to match my local machine output. But when I pushed the changes, it still failed on github actions!

I updated the test to mock the getFormattedReleaseDate function instead

@tameremad tameremad merged commit 266e775 into main Feb 23, 2023
@tameremad tameremad deleted the TE/homepage-1 branch February 23, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants