Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Application and Team on Release Dialog #586

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

tameremad
Copy link
Contributor

@tameremad tameremad commented Mar 28, 2023

  • move the envs[] from release dialog props type into testdata type. in release dialog test
  • show the app name on release dialog
  • show team name also when it's available
  • refactor a little in release dialog test (fix the red squiggles)

SRX-HLVCYS

@hannesg
Copy link
Member

hannesg commented Mar 30, 2023

Lgtm!

@tameremad tameremad requested a review from hannesg March 30, 2023 15:45
@tameremad tameremad merged commit fd97c7c into main Mar 30, 2023
@tameremad tameremad deleted the TE/show-team-app-on-dialog branch March 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants