Fix bug in app deletion when there are app locks #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a lock on the app, and gets a request to delete an app, the server returns an error. Now the client gets the information (in advance as part of the undeploySummary) and will not show the button if there is an app lock. Env locks are not considered for deletion of apps.
sven-urbanski-freiheit-com
force-pushed
the
su-forbid-deletion-with-locks
branch
from
894884c to
4cd920b
Compare
hannesg
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an app lock while deleting an app, we ignore the lock (and delete it too).
Env locks are not considered or touched for deletion of apps.