Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Release Dialog to open via query parameters #619

Merged
merged 7 commits into from
Apr 11, 2023

Conversation

tameremad
Copy link
Contributor

@tameremad tameremad commented Apr 10, 2023

The two query parameters dialog-app and dialog-version open the dialog automatically. the release card would set the parameters to show a new dialog. closing the dialog will simply clear the parameters.

  • delete the useReleaseInfo hook from the store.
  • useOpenReleaseDialog to add the query params for some app/version
  • useCloseReleaseDialog to clear those params
  • useReleaseDialogParams to get the app/version from the URL and verify that they represent an actual release. => Then open the dialog.
  • remove the release dialog store

@sven-urbanski-freiheit-com
Copy link
Contributor

Please adapt the commit message (header and body) to explain what you achieved first (then afterwards you can go into details about the changed functions that you mention)
e.g. as a first line
Allow ReleaseDialog to open via query parameters

And then something like this: (not 100% correct)
The query parameters (name1, name2) are used to open he release dialog automatically on the release page. On other pages the parameters will be ignored....

@tameremad tameremad changed the title Add query parameters for App/Version in Release Dialogs. Allow Release Dialog to open via query parameters Apr 11, 2023
@tameremad tameremad merged commit b05635e into main Apr 11, 2023
@tameremad tameremad deleted the TE/rel-dialog-links branch April 11, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants