Introduce eslint rule against type assertions #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
changed the title
jaypontes
approved these changes
Apr 14, 2023
sven-urbanski-freiheit-com
deleted the
su-enable-eslint-no-type-assertion2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forbids type assertions.
As a first step, all current assertions are allowed with the comment
eslint-disable-next-line no-type-assertion/no-type-assertion.This is just the first step: There will be more PRs that get rid of the issue properly, e.g. refactoring the code to make the type assertion unnecessary.