Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Display locks only for the correct application #787

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

sebastianmueller
Copy link
Contributor

In the previous implementation locks would also be displayed on apps that names are contained in a locked app's name.

@sebastianmueller sebastianmueller requested a review from a team as a code owner July 5, 2023 16:02
In the previous implementation locks would also be displayed on apps that
names are contained in a locked app's name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep the fuzzyness on the lockspage.
Maybe split up in 2 functions, name one "fuzzy" the other "exact", and use the fuzzy one on the lockspage.

@sebastianmueller
Copy link
Contributor Author

we should keep the fuzzyness on the lockspage. Maybe split up in 2 functions, name one "fuzzy" the other "exact", and use the fuzzy one on the lockspage.

Changed searchCustomFilter back. Not sure though if a special function is needed for this case.

@sebastianmueller sebastianmueller merged commit 6156366 into main Jul 6, 2023
@sebastianmueller sebastianmueller deleted the fix-lock-display branch July 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants