Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autorebase when behind base branch option for renovate #798

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

ahmed-nour-fdc
Copy link
Contributor

  • DIsable autorebase for renovate.
  • Change schedule to be daily.

@ahmed-nour-fdc ahmed-nour-fdc requested a review from a team as a code owner July 7, 2023 12:29
@hannesg
Copy link
Member

hannesg commented Jul 7, 2023

Could you explain why we should not use autorebase?

@sven-urbanski-freiheit-com
Copy link
Contributor

Could you explain why we should not use autorebase?

It's just very spammy and mostly not necessary.
If we merge 1 change, N builds would be retriggered.

@ahmed-nour-fdc
Copy link
Contributor Author

Could you explain why we should not use autorebase?

Renovate should only run on a schedule to check wether there is a package that needs to be updated, but currently with autorebase it runs whenever a commit is merged which causes lots of emails to be sent for no real reason.
I think once per day should be sufficient.

@hannesg
Copy link
Member

hannesg commented Jul 7, 2023

Makes sense. LGTM!

@ahmed-nour-fdc ahmed-nour-fdc merged commit 90bd08d into main Jul 7, 2023
@ahmed-nour-fdc ahmed-nour-fdc deleted the AN/disable-renovate-autorebase branch July 7, 2023 12:48
@@ -35,9 +35,7 @@
"gomodUpdateImportPaths",
"gomodTidy"
],
"rebaseWhen": "behind-base-branch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to set this to "conflicted" excplicitely. Not sure about the default value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants