Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC policy parser methods #806

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

bernardo-bastos
Copy link
Collaborator

Adds the RBAC policy parser methods.

Rev: DSN-CV2ND9

@bernardo-bastos bernardo-bastos requested a review from a team as a code owner July 13, 2023 11:12
pkg/auth/rbac.go Outdated Show resolved Hide resolved
pkg/auth/rbac.go Show resolved Hide resolved
services/cd-service/pkg/cmd/server.go Outdated Show resolved Hide resolved
@bernardo-bastos bernardo-bastos merged commit a81d481 into main Jul 14, 2023
@bernardo-bastos bernardo-bastos deleted the bb/DSN-CV2ND9/add_rbac_methods branch July 14, 2023 17:24

// Stores the RBAC allowed Applications and Actions
type RBACconfig struct {
allowedApp []string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename to allowedApps

return fmt.Errorf("invalid action %s", action)
}

func (c *RBACconfig) validateEnvs(env string) error {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename env -> envs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants