Do not render undeployed argoApps #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-skip-nondeployed
branch
from
1670973 to
22abaa8
Compare
leandro-freiheit
approved these changes
Aug 4, 2023
sven-urbanski-freiheit-com
force-pushed
the
su-skip-nondeployed
branch
from
22abaa8 to
f43afaa
Compare
ArgoCd cannot find the manifest file for undeployed apps, so it will render an error in the ui.
sven-urbanski-freiheit-com
force-pushed
the
su-skip-nondeployed
branch
from
f43afaa to
89d414b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the error in argoCd
rpc error: code = Unknown desc = environments/<env>/applications/<app>/manifests: app path does not existThis is usually a problem when creating a new app, because generally all manifest are created in the source repo at once, including for production environments.
However, once submitted to kuberpult via /release endpoint, kuberpult rendered the ArgoCd manifests for all environments, even those that are not deployed yet (like production).
With this change, kuberpult will only render the apps in an environment, if it is deployed there.
Reference: SRX-638BGR