-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell ArgoCd to sync apps #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-argo-webhook-invocation
branch
from
August 17, 2023 17:05
402ed36
to
f8820a4
Compare
sven-urbanski-freiheit-com
changed the title
WIP argoCd webhook invocation
Tell ArgoCd to sync apps
Aug 18, 2023
mibo-fdc
approved these changes
Aug 18, 2023
ahmed-nour-fdc
approved these changes
Aug 18, 2023
sven-urbanski-freiheit-com
force-pushed
the
su-argo-webhook-invocation
branch
from
August 21, 2023 08:15
2242195
to
f528c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature, kuberpult sends webhooks that imitate github webhooks to argoCd, which trigger argoCds refreshs.
This is intended to reduce load on ArgoCd. Normally, argoCd renders all manifests again whenever there is a new commit in the manifest repository. However, with Webhooks, it only checks the actually changed files that are part of the Webhook body.
Note that this does not work for all cases, like deletion of environments from apps.
So you can make the "timeout.reconciliation" in argoCd bigger (e.g. 30min instead of the default 3min) - however you should not fully disable it. See https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability/#argocd-application-controller
To enable this kuberpult feature, set
argocd.server
in the helm chart to a hostname that reaches argoCds "argocd-server", usually this should behttp://argocd-server.${ARGO_NAMESPACE}.svc.cluster.local
.If the certificate for the https connection is not accepted, set
argocd.insecure: true
.This is usually safe, under the assumption that kuberpult and argoCd run on the same cluster anyway.
This feature is intended to be used when Webhooks are not an option for you (for example due to firewall policies).
Caveat: Kuberpult only retries failed connections a very limited number of times. That means, if argoCd does not react temporarily, webhooks may get lost, and therefore argoCd does not sync until the reconciliation timeout.