Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell ArgoCd to sync apps #872

Merged
merged 11 commits into from
Aug 21, 2023
Merged

Conversation

sven-urbanski-freiheit-com
Copy link
Contributor

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com commented Aug 17, 2023

With this feature, kuberpult sends webhooks that imitate github webhooks to argoCd, which trigger argoCds refreshs.

This is intended to reduce load on ArgoCd. Normally, argoCd renders all manifests again whenever there is a new commit in the manifest repository. However, with Webhooks, it only checks the actually changed files that are part of the Webhook body.

Note that this does not work for all cases, like deletion of environments from apps.

So you can make the "timeout.reconciliation" in argoCd bigger (e.g. 30min instead of the default 3min) - however you should not fully disable it. See https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability/#argocd-application-controller

To enable this kuberpult feature, set argocd.server in the helm chart to a hostname that reaches argoCds "argocd-server", usually this should be http://argocd-server.${ARGO_NAMESPACE}.svc.cluster.local.

If the certificate for the https connection is not accepted, set argocd.insecure: true.
This is usually safe, under the assumption that kuberpult and argoCd run on the same cluster anyway.

This feature is intended to be used when Webhooks are not an option for you (for example due to firewall policies).

Caveat: Kuberpult only retries failed connections a very limited number of times. That means, if argoCd does not react temporarily, webhooks may get lost, and therefore argoCd does not sync until the reconciliation timeout.

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com requested a review from a team as a code owner August 17, 2023 16:59
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com changed the title WIP argoCd webhook invocation Tell ArgoCd to sync apps Aug 18, 2023
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com deleted the su-argo-webhook-invocation branch August 21, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants