Distinguish more rollout states #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
approved these changes
Oct 2, 2023
leandro-freiheit
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the rollout_lag metrics, I noticed that they sometimes jump from zero to several days and back to zero. I inspected this and it turned out that these apps are just becoming unhealthy and recover. In that case the rollout_lag should not go up again. In order to solve this, I added two more intermediate states to the rollout states.
progressing( = change not applied yet ) is split up intoprogressing( = argocd is working on it ) andpending( = argocd has not picked it up yet )error( = something failed ) is split up intoerror( = sync failed ) andunhealthy( = health is degraded )