Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to update an entity's ID #537

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Added service to update an entity's ID #537

merged 1 commit into from
Jan 11, 2024

Conversation

carlos-sarmiento
Copy link
Contributor

@carlos-sarmiento carlos-sarmiento commented Jan 8, 2024

Description

Add a new service to update an entity's Entity ID.

Motivation and Context

I run a rather large and sprawling Home Assistant instance. Sometimes I add an integration that creates 20+ entities. I don't like the way HA automatically builds the entity_id for new devices/entites and so have to manually go and rename them. The idea behind this is that, instead of having to manually rename every entity, or shutdown home assistant and mess with the entity_registry file in .storage I can do a bunch of service calls and get the result I want.

How has this been tested?

Used on my own instance to rename entities. Service call was simple enough

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@carlos-sarmiento
Copy link
Contributor Author

PR is missing the change to the entities documentation page. Wanted to make sure the change is welcomed before updating that and creating the screenshot

@carlos-sarmiento carlos-sarmiento marked this pull request as ready for review January 8, 2024 19:27
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

Some small comments, and indeed: Docs :)

../Frenck

custom_components/spook/services.yaml Outdated Show resolved Hide resolved
@frenck frenck added the new-feature New features or options. label Jan 9, 2024
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@carlos-sarmiento
Copy link
Contributor Author

Updated everything. Should be ready to merge

Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @carlos-sarmiento 👍

../Frenck

@frenck frenck merged commit 825ba70 into frenck:main Jan 11, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants