-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #811
base: main
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe update introduces structured JSON configurations in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
Additional comments not posted (2)
custom_components/spook/integrations/spook_inverse/translations/et.json (2)
2-29
: Theconfig
section is well-structured and complete.The JSON structure for configuring binary sensors and switches is logically organized, with clear and descriptive keys. The localization appears accurate.
30-39
: Theoptions
section is consistent and well-organized.The structure mirrors the
config
section, providing additional configurability for binary sensors. The localization and organization are clear and accurate.
5687c40
to
46fa6b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
- custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Additional comments not posted (2)
custom_components/spook/integrations/spook_inverse/translations/ko.json (1)
1-11
: Well-structured JSON configuration for Korean translations.The new JSON structure for binary sensors is correctly localized and enhances the configuration options for Korean-speaking users. The structure is clear and well-organized.
custom_components/spook/integrations/spook_inverse/translations/et.json (1)
1-40
: Comprehensive JSON configuration for Estonian translations.The new JSON structure provides detailed configuration and options for binary sensors and switches, enhancing usability for Estonian-speaking users. The organization and localization are well-executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Additional comments not posted (6)
custom_components/spook/integrations/spook_inverse/translations/ko.json (6)
4-11
: Check the translation consistency forbinary_sensor
.Ensure that the translation for "출처 구성요소" (source component) and "출처 구성요소 숨김" (hide source) is consistent across similar contexts.
12-19
: Verify the translation and structure forswitch
.The structure and translations for
switch
should match the intended functionality. Ensure consistency withbinary_sensor
.
20-27
: Ensure correctness ofuser
object translations.The
description
andmenu_options
should accurately reflect the functionality for reversing states. Verify the appropriateness of the translations.
32-39
: Ensure consistency inbinary_sensor
options.The
options
forbinary_sensor
should maintain consistency with theconfig
section. Verify translation accuracy.
40-47
: Verifyswitch
options structure and translations.Ensure that the
switch
options are consistent with theconfig
section and translations are accurate.
50-50
: Verify the appropriateness of thetitle
.Ensure that the title "반전 👻" (Reversal 👻) is suitable for the context and consistent throughout the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
Files skipped from review due to trivial changes (1)
- custom_components/spook/integrations/spook_inverse/translations/fi.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- custom_components/spook/integrations/spook_inverse/translations/fi.json
Currently translated at 66.6% (14 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/et/
Currently translated at 4.7% (1 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ko/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ko/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/fi/
Currently translated at 19.0% (4 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ca/
9eb246f
to
9f762b9
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- custom_components/spook/integrations/spook_inverse/translations/ca.json (1 hunks)
- custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
- custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
- custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Files skipped from review due to trivial changes (1)
- custom_components/spook/integrations/spook_inverse/translations/fi.json
Additional comments not posted (8)
custom_components/spook/integrations/spook_inverse/translations/ca.json (2)
2-15
: LGTM!The
config
section is correctly structured and the data fields are appropriately named.The code changes are approved.
16-29
: LGTM!The
options
section is correctly structured and the data fields are appropriately named.The code changes are approved.
custom_components/spook/integrations/spook_inverse/translations/et.json (3)
2-29
: LGTM!The
config
section is correctly structured and the data fields are appropriately named.The code changes are approved.
30-39
: LGTM!The
options
section is correctly structured and the data fields are appropriately named.The code changes are approved.
20-27
: LGTM!The
user
section is correctly structured and the descriptions are clear.The code changes are approved.
custom_components/spook/integrations/spook_inverse/translations/ko.json (3)
2-29
: LGTM!The
config
section is correctly structured and the data fields are appropriately named.The code changes are approved.
30-49
: LGTM!The
options
section is correctly structured and the data fields are appropriately named.The code changes are approved.
20-27
: LGTM!The
user
section is correctly structured and the descriptions are clear.The code changes are approved.
Translations update from Hosted Weblate for Spook/Inverse helper.
Current translation status: