Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #811

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Aug 9, 2024

Translations update from Hosted Weblate for Spook/Inverse helper.

Current translation status:

Weblate translation status

Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

Walkthrough

The update introduces structured JSON configurations in et.json, ko.json, and fi.json for the spook_inverse integration, defining settings for binary sensors and switches. Each file now includes comprehensive sections for config and options, enhancing user interaction through clear definitions and localized support. The transformation from empty objects to detailed structures improves usability and functionality for managing entity behaviors.

Changes

Files Change Summary
custom_components/spook/integrations/spook_inverse/... Enhanced et.json and ko.json with structured JSON configurations for config and options, detailing binary sensors and switches for better usability.
custom_components/spook/integrations/spook_inverse/... Added a new fi.json file with structured JSON for Finnish translations, supporting localization for Finnish-speaking users.
custom_components/spook/integrations/spook_inverse/... Introduced ca.json with structured JSON for binary_sensor and switch, specifying a name key for improved configuration.

Poem

🐰 In the digital glade where sensors play,
New options bloom like flowers in the day.
With a hop and a skip, they dance in delight,
Reversing their roles, making everything right.
So let’s cheer for the change, let joy take its flight! 🌸✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d9bac56 and 5687c40.

Files selected for processing (1)
  • custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
Additional comments not posted (2)
custom_components/spook/integrations/spook_inverse/translations/et.json (2)

2-29: The config section is well-structured and complete.

The JSON structure for configuring binary sensors and switches is logically organized, with clear and descriptive keys. The localization appears accurate.


30-39: The options section is consistent and well-organized.

The structure mirrors the config section, providing additional configurability for binary sensors. The localization and organization are clear and accurate.

@weblate weblate force-pushed the weblate-spook-inverse-helper branch from 5687c40 to 46fa6b3 Compare August 12, 2024 10:57
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5687c40 and 46fa6b3.

Files selected for processing (2)
  • custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
  • custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Additional comments not posted (2)
custom_components/spook/integrations/spook_inverse/translations/ko.json (1)

1-11: Well-structured JSON configuration for Korean translations.

The new JSON structure for binary sensors is correctly localized and enhances the configuration options for Korean-speaking users. The structure is clear and well-organized.

custom_components/spook/integrations/spook_inverse/translations/et.json (1)

1-40: Comprehensive JSON configuration for Estonian translations.

The new JSON structure provides detailed configuration and options for binary sensors and switches, enhancing usability for Estonian-speaking users. The organization and localization are well-executed.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 46fa6b3 and 716623b.

Files selected for processing (1)
  • custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Additional comments not posted (6)
custom_components/spook/integrations/spook_inverse/translations/ko.json (6)

4-11: Check the translation consistency for binary_sensor.

Ensure that the translation for "출처 구성요소" (source component) and "출처 구성요소 숨김" (hide source) is consistent across similar contexts.


12-19: Verify the translation and structure for switch.

The structure and translations for switch should match the intended functionality. Ensure consistency with binary_sensor.


20-27: Ensure correctness of user object translations.

The description and menu_options should accurately reflect the functionality for reversing states. Verify the appropriateness of the translations.


32-39: Ensure consistency in binary_sensor options.

The options for binary_sensor should maintain consistency with the config section. Verify translation accuracy.


40-47: Verify switch options structure and translations.

Ensure that the switch options are consistent with the config section and translations are accurate.


50-50: Verify the appropriateness of the title.

Ensure that the title "반전 👻" (Reversal 👻) is suitable for the context and consistent throughout the application.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 716623b and 24def5d.

Files selected for processing (1)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 24def5d and 9eb246f.

Files selected for processing (1)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json

indkilech and others added 6 commits August 28, 2024 21:09
Currently translated at 66.6% (14 of 21 strings)

Translation: Spook/Inverse helper
Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/et/
Currently translated at 4.7% (1 of 21 strings)

Translation: Spook/Inverse helper
Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ko/
Currently translated at 100.0% (21 of 21 strings)

Translation: Spook/Inverse helper
Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ko/
Currently translated at 100.0% (21 of 21 strings)

Translation: Spook/Inverse helper
Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/fi/
Currently translated at 19.0% (4 of 21 strings)

Translation: Spook/Inverse helper
Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/ca/
@weblate weblate force-pushed the weblate-spook-inverse-helper branch from 9eb246f to 9f762b9 Compare August 28, 2024 19:09
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9eb246f and 9f762b9.

Files selected for processing (4)
  • custom_components/spook/integrations/spook_inverse/translations/ca.json (1 hunks)
  • custom_components/spook/integrations/spook_inverse/translations/et.json (1 hunks)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json (1 hunks)
  • custom_components/spook/integrations/spook_inverse/translations/ko.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • custom_components/spook/integrations/spook_inverse/translations/fi.json
Additional comments not posted (8)
custom_components/spook/integrations/spook_inverse/translations/ca.json (2)

2-15: LGTM!

The config section is correctly structured and the data fields are appropriately named.

The code changes are approved.


16-29: LGTM!

The options section is correctly structured and the data fields are appropriately named.

The code changes are approved.

custom_components/spook/integrations/spook_inverse/translations/et.json (3)

2-29: LGTM!

The config section is correctly structured and the data fields are appropriately named.

The code changes are approved.


30-39: LGTM!

The options section is correctly structured and the data fields are appropriately named.

The code changes are approved.


20-27: LGTM!

The user section is correctly structured and the descriptions are clear.

The code changes are approved.

custom_components/spook/integrations/spook_inverse/translations/ko.json (3)

2-29: LGTM!

The config section is correctly structured and the data fields are appropriately named.

The code changes are approved.


30-49: LGTM!

The options section is correctly structured and the data fields are appropriately named.

The code changes are approved.


20-27: LGTM!

The user section is correctly structured and the descriptions are clear.

The code changes are approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants