Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean Translations #812

Closed
wants to merge 1 commit into from
Closed

Conversation

saya6k
Copy link

@saya6k saya6k commented Aug 12, 2024

Description

안녕하세요, Spook!

Motivation and Context

Weblate Korean Translation was so awful so I translated from scratch.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • [v] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarcloud bot commented Aug 12, 2024

Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations of Spook are not managed here.

Please, see the documentation of Spook on how to contribute to its translations here:

https://spook.boo/development#translating-spook

../Frenck

@frenck frenck closed this Aug 12, 2024
@saya6k saya6k deleted the translation_ko branch August 12, 2024 10:48
@saya6k
Copy link
Author

saya6k commented Aug 12, 2024

I uploaded it to Weblate. Sorry to bother you!

Copy link

coderabbitai bot commented Aug 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent updates to the Korean translations for the "Spook" component of Home Assistant significantly enhance clarity and user engagement. Key improvements include refined abort messages, expanded entity translations, and clearer descriptions of issues, all tailored for Korean-speaking users. These changes not only ensure accurate terminology but also foster a more user-friendly experience, aligning with the overall goal of improving accessibility and understanding within the platform.

Changes

Files Change Summary
custom_components/spook/translations/ko.json Major updates to the Korean translations, including enhanced abort messages, expanded entity names, and clearer issue descriptions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Spook
    participant HomeAssistant

    User->>Spook: Initiate configuration
    Spook->>User: Display welcome message
    User->>Spook: Confirm understanding of README
    Spook->>User: Present configuration options
    User->>Spook: Choose to restart
    Spook->>HomeAssistant: Restart for changes
    HomeAssistant-->>User: Configuration updated
Loading

Poem

Hop, hop, hooray, with translations anew,
Clarity and joy, for me and for you!
Messages refined, entities more bright,
Spook guides us gently, through day and through night.
🐇✨ Let’s dance with delight, our journey's in sight!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck
Copy link
Owner

frenck commented Aug 12, 2024

I uploaded it to Weblate. Sorry to bother you!

No worries! I appreciate the help! 👍

../Frenck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants