feat: add support to chagne scatter symbol size #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmatthias
reviewed
Oct 19, 2024
| @@ -24,6 +24,12 @@ export function generateCandleSeries( | |||
| }, | |||
| showSymbol: false, | |||
| }; | |||
| if (value.type === ChartType.scatter) { | |||
| sp['symbolSize'] = value.scatterSymbolSize; | |||
There was a problem hiding this comment.
we'll need a fallback here.
symbolSize can't be undefined - which it is if you have an existing plot-config with scatter (checkout main, create a new plot config with a scatter plot - close the page (due to a HMR bug in pinia-persisted-state it seems)- checkout your branch and reopen the page - notice that the scatter plot doesn't render).
xmatthias
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the echarts default symbol size (10px) when plotting scatter indicators. This PR changes the default symbol size to 3px and adds a spin button to adjust the value.
Before:
After: