1472 upgrade to polkadot release v0942 #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 25, 2023 18:31
mattheworris
force-pushed
the
1472-upgrade-to-polkadot-release-v0942
branch
from
ae1f8ad to
e0754c6
Compare
wilwade
reviewed
May 30, 2023
pallets/messages/src/rpc/src/lib.rs
Outdated
| @@ -100,7 +99,7 @@ where | |||
| 'loops: for block_number in from..to { | |||
| let list: Vec<MessageResponse> = api | |||
| .get_messages_by_schema_and_block( | |||
| &at, | |||
| self.client.info().best_hash, | |||
There was a problem hiding this comment.
I think this is a function call and not memoized, so we'd need to keep the at so it doesn't get called n times.
There was a problem hiding this comment.
Nice catch, I didn't catch the loop part, focused on the BlockId removal.
wilwade
reviewed
May 30, 2023
pallets/msa/src/rpc/src/lib.rs
Outdated
| let results = delegator_msa_ids | ||
| .par_iter() | ||
| .map(|delegator_msa_id| { | ||
| let api = self.client.runtime_api(); | ||
| // api.has_delegation returns Result<bool, ApiError>), so _or(false) should not happen, | ||
| // but just in case, protect against panic | ||
| let has_delegation: bool = match api.has_delegation( | ||
| &at, | ||
| self.client.info().best_hash, |
There was a problem hiding this comment.
Another here that is inside a loop
wilwade
reviewed
May 30, 2023
| /// Storage: System Account (r:999 w:999) | ||
| /// Proof: System Account (max_values: None, max_size: Some(128), added: 2603, mode: MaxEncodedLen) | ||
| /// The range of component `u` is `[1, 1000]`. | ||
| fn upgrade_accounts(u: u32, ) -> Weight { |
There was a problem hiding this comment.
Are we going to need to call this once it is deployed to do the migration?
There was a problem hiding this comment.
I think so, there is a release note about needing to run an upgrade script. I grabbed this code from substrate to get things compiling, I'll check the benchmark output to see if this comes out correct.
wilwade
reviewed
May 30, 2023
github-actions
bot
added
the
metadata-changed
github-actions
bot
added
metadata-changed
|
Replaced with #1590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is
Closes
Discussion
Checklist