bugfix: schema name migration #2012
Conversation
aramikm
requested review from
shannonwells,
mattheworris,
enddynayn,
claireclark1 and
saraswatpuneet
Codecov ReportAttention: Patch coverage is
|
github-actions
bot
added
the
metadata-changed
There was a problem hiding this comment.
Looks good--one question/discussion point: would it be worthwhile to add a script/program somewhere that could be run (manually, I guess) against mainnet after an upgrade to validate things from a client perspective? Might be a useful pattern to have in place for future migrations...
Otherwise, 🚢 it!
| // check to ensure updates took place | ||
| let known_schemas = get_known_schemas::<T>(); | ||
| for (schema_id, schema_name) in known_schemas.into_iter() { | ||
| // safe to use unwrap since only used in try_runtime |
There was a problem hiding this comment.
Curious nit: why doesn't lint complain about unwrap here? I don't see it disabled at the top of the file?
There was a problem hiding this comment.
It might be since it's under "try-runtime" feature flag
| @@ -1,4 +1,2 @@ | |||
| /// migrations to v2 | |||
| pub mod v2; | |||
| /// migrations to v3 | |||
| pub mod v3; | |||
There was a problem hiding this comment.
Shouldn't this one go away as well?
There was a problem hiding this comment.
I wanted to keep at least the last migration for each pallet for easier access but I can remove this usage part so it does not get included in the code.
|
Why not submit transactions for these instead of writing a migration script? |
Good question!
|
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
Goal
The goal of this PR is to make to fix the schema names on main-net that incorrectly got updated with test-net values.
Closes #2006
Changes
Checklist
Verification on Mainnet
Verification on Paseo