Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passkey miscellaneous checks part 1 #2060

Merged
merged 57 commits into from
Jul 10, 2024
Merged

Passkey miscellaneous checks part 1 #2060

merged 57 commits into from
Jul 10, 2024

Conversation

saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Jul 6, 2024 •
edited
Loading

Goal

The goal of this PR is to incorporate more checks for passkey extrinsic inline with other SignedExtras

  • Non Zero Sender Check
  • Spec Check
  • Tx version check
  • Era check
  • Genesis check

Closes #2031

Discussion

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

saraswatpuneet and others added 30 commits June 18, 2024 11:23
@saraswatpuneet
check account signature on passkey
9628adb
@saraswatpuneet
reference
521919e
@saraswatpuneet
setup mock and account types
5e035f6
@saraswatpuneet
set unused flag for now
2a5edbb
@saraswatpuneet
fix build
079f764
@saraswatpuneet
address feedback
e387a2d
@saraswatpuneet
set correct AccountId in mock
7195c75
@saraswatpuneet
set spec version in future
b0f4699
@saraswatpuneet
update spec version
913b619
@saraswatpuneet
sync with types PR
3535034
@saraswatpuneet
cleanup
2fbec5a
@saraswatpuneet
set pallet balances as dependency
e6ceee2
@saraswatpuneet
refactor common types from payment
3730996
@saraswatpuneet
withdraw tx fee
a395a83
@saraswatpuneet
lint
a3454dc
@saraswatpuneet
Merge branch 'main' into passkey_tx_charge
b69ca9b
@saraswatpuneet
Merge branch 'main' into passkey_tx_charge
04eeb69
@saraswatpuneet
set functions to charge tx fees
4acf6bf
@saraswatpuneet
add negative test without funds fails
d952208
@saraswatpuneet
charge tx and add tests
04329f1
@saraswatpuneet
cleanup
339642a
@saraswatpuneet
Merge branch 'main' into passkey_tx_charge
c130441
@saraswatpuneet
cleanup
40eed8b
@saraswatpuneet
charge fee post validation
88ae756
@saraswatpuneet
add more tests
ab7488a
@saraswatpuneet
improve logic
5b91e44
@saraswatpuneet
docs
df1de03
@saraswatpuneet
Merge branch 'main' into passkey_tx_charge
d3fbc5e
@saraswatpuneet
Merge branch 'main' into passkey_tx_charge
c4445c0
@saraswatpuneet
improve pattern inline with signed ext
c4a8da3
@saraswatpuneet saraswatpuneet requested review from a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team July 8, 2024 19:00
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 8, 2024
aramikm
aramikm reviewed Jul 8, 2024
View reviewed changes
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 8, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 8, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 9, 2024
enddynayn
enddynayn approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@enddynayn
Copy link
Collaborator

This is great. I wonder if we need to add some test here?

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 10, 2024
@saraswatpuneet saraswatpuneet enabled auto-merge (squash) July 10, 2024 14:03
mattheworris
mattheworris approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
🚢 it!

@saraswatpuneet saraswatpuneet merged commit 1b583a7 into main Jul 10, 2024
27 checks passed
@saraswatpuneet saraswatpuneet deleted the passkey_miscellaneous_1 branch July 10, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworris mattheworris mattheworris approved these changes

@enddynayn enddynayn enddynayn approved these changes

@aramikm aramikm aramikm approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@shannonwells shannonwells Awaiting requested review from shannonwells shannonwells was automatically assigned from frequency-chain/pr-reviewers

@claireolmstead claireolmstead Awaiting requested review from claireolmstead claireolmstead was automatically assigned from frequency-chain/pr-reviewers

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055 JoeCap08055 was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Passkey- implement misc validations
4 participants
@saraswatpuneet @enddynayn @mattheworris @aramikm