passkey: reorder validation and some docs #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
requested review from
shannonwells,
enddynayn,
saraswatpuneet,
JoeCap08055,
mattheworris and
claireclark1
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
shannonwells
approved these changes
Jul 12, 2024
aramikm
commented
Jul 12, 2024
Comment on lines
+21
to
+23
| Because the Polkadot SDK currently lacks support for P256 signatures, we had to use an unsigned | ||
| extrinsic to allow this custom verification before dispatching transactions. To achieve this, we | ||
| added P256 signature verification within the `ValidateUnsigned` trait implementation for the pallet. |
There was a problem hiding this comment.
@shannonwells I'm still not happy with this. Any idea how we might make this better?
This was referenced Jul 12, 2024
Merged
aramikm
added a commit
that referenced
this pull request
Jul 13, 2024
# Goal There was a misunderstanding before that we thought if the fee was deducted from account in pre_dispatch and after that any failure happens inside pre_dispatch, only post_dispatch would be able to refund that amount but that was not a correct assumption and the caller of pre_dispatch is going to reverse all storage changes in it does not return with Ok. based on `/// Changes made to storage *WILL* be persisted if the call returns `Ok`.` Knowing this, we could put the signature check as the final validation since it is the heaviest one. Related to #2071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to re order the validations to be as close as possible to the signed extension order considering the customizations that we did such as not having post_dispatch implemented.
Related to #2032