passkeys: calculate weights #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
aramikm
changed the title
aramikm
requested review from
shannonwells,
enddynayn,
claireolmstead,
saraswatpuneet,
mattheworris and
JoeCap08055
saraswatpuneet
approved these changes
Jul 15, 2024
aramikm
commented
Jul 15, 2024
| Weight::from_parts(1_015_000_000, 5078) | ||
| .saturating_add(T::DbWeight::get().reads(2_u64)) | ||
| .saturating_add(T::DbWeight::get().writes(1_u64)) | ||
| // Minimum execution time: 1_745_366_000 picoseconds. |
There was a problem hiding this comment.
@wilwade After running the weights in CI it looks like it is actually close to 2 billion instead if 1. Which means the transactions would be even more expensive.
JoeCap08055
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to calculate accurate weights for passkey pallet
Related to #2032
Checklist