chore(genesis): move development genesis config to runtime #2152

enddynayn · 2024-09-05T14:32:50Z

Move Development Genesis Config to the Runtime to
support decoupling of client and runtime dependencies.

When running chain-spec-builder, the following command:

chain-spec-builder list-presets –-runtime-wasm-path ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm

Outputs:
With feature flags "frequency-no-relay", "frequency-local" enabled:

{“presets”:[“development”, "frequency-local", "frequency"]}

Additionally, when running:

chain-spec-builder display-preset --runtime-wasm-path ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm --preset-name development

it outputs the development genesis config:

{"aura":{"authorities":[]},"auraExt":{},"balances":{ ...} ... }

With feature flags "frequency" only, mainnet presets show up:

{“presets”:["frequency"]}

Additionally, when running:

chain-spec-builder display-preset --runtime-wasm-path ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm --preset-name frequency

it outputs the frequency genesis config:

{"aura":{"authorities":[]},"auraExt":{},"balances":{ ...} ... }

#2149
#2142

codecov · 2024-09-05T14:48:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

runtime/frequency/src/development_genesis.rs

JoeCap08055

Reviewed changes
Built & ran node, verified genesis config
Ran unit & e2e tests, passing

wilwade

Haven't gotten all the way through, but wanted to call out one fix. The rest looks good so far. Excited to see this happening!

runtime/frequency/src/lib.rs

aramikm

Overall looks good one concern is bloating the size of runtime wasm. We already know wasm has a size limit on the polkadot and if it's bigger than a certain size the upgrade won't work.

runtime/frequency/src/apis.rs

mattheworris

Read through changes

🚢 it!

deny.toml

My own review

aramikm

Added some questions and nits.

.github/workflows/verify-pr-commit.yml

node/service/src/chain_spec/frequency_paseo.rs

runtime/frequency/src/development_genesis.rs

Move Development Genesis Config to the Runtime to support decoupling of client and runtime dependencies. When running `chain-spec-builder`, the following command: ``` chain-spec-builder list-presets –-runtime-wasm-path ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm ``` outputs: ``` {“presets”:[“development”]} ``` Additionally, when running: ``` chain-spec-builder display-preset --runtime-wasm-path ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm --preset-name development ``` it outputs the development genesis config: ``` {"aura":{"authorities":[]},"auraExt":{},"balances":{ ...} ... } ``` issue-2149 issue-2142

Move the Frequency and Paseo genesis configurations to the runtime. Additionally, refactor the genesis builder for Paseo, Frequency, and Development into a single genesis_builder function.

aramikm

Reviewed the code and looked good.

aramikm · 2024-09-30T21:55:11Z

runtime/frequency/src/apis.rs

+			vec![
+				sp_genesis_builder::PresetId::from("development"),
+				sp_genesis_builder::PresetId::from("frequency-local"),
+				sp_genesis_builder::PresetId::from("frequency"),


question: why do you need frequency for local features?

Good question! This is something I mentioned during our stand-up, and I believe we agreed that having the frequency feature enabled by default was ok.

mattheworris

Read through changes

claireclark1

Read through this PR. Was mainly focused on code organization and naming since I'm not a pro in all of the rust semantics. That being said, looks good to me!

Can you please take another look? Requesting a new review because of new changes.

JoeCap08055

Looks good!

Ran unit tests
Ran e2e tests
Inspected build with chain-spec-builder

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch 2 times, most recently from adb092a to 66145ee Compare September 5, 2024 14:54

enddynayn changed the title ~~Chore/mv development genesis to runtime issue 2149~~ chore(genesis): move development genesis config to runtime Sep 5, 2024

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch 2 times, most recently from 7a032a9 to 28770ba Compare September 5, 2024 15:30

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 6, 2024

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch from 17d61a3 to bd280f3 Compare September 6, 2024 17:11

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 6, 2024

enddynayn commented Sep 6, 2024

View reviewed changes

runtime/frequency/src/development_genesis.rs Outdated Show resolved Hide resolved

enddynayn commented Sep 6, 2024

View reviewed changes

runtime/frequency/src/development_genesis.rs Outdated Show resolved Hide resolved

enddynayn marked this pull request as ready for review September 6, 2024 18:11

enddynayn requested a review from wilwade as a code owner September 6, 2024 18:11

enddynayn requested review from aramikm, claireclark1, mattheworris and saraswatpuneet September 6, 2024 18:13

enddynayn commented Sep 6, 2024

View reviewed changes

runtime/frequency/src/development_genesis.rs Outdated Show resolved Hide resolved

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 6, 2024

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch from 820ea2c to 26952b6 Compare September 6, 2024 19:15

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 6, 2024

JoeCap08055 previously approved these changes Sep 6, 2024

View reviewed changes

wilwade previously requested changes Sep 6, 2024

View reviewed changes

runtime/frequency/src/lib.rs Outdated Show resolved Hide resolved

aramikm approved these changes Sep 6, 2024

View reviewed changes

runtime/frequency/src/apis.rs Show resolved Hide resolved

enddynayn mentioned this pull request Sep 6, 2024

Feature flag each presets for frequency, frequency-testnet and frequency-local. #2153

Closed

mattheworris approved these changes Sep 6, 2024

View reviewed changes

claireclark1 reviewed Sep 6, 2024

View reviewed changes

deny.toml Outdated Show resolved Hide resolved

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 27, 2024

wilwade requested review from mattheworris, claireclark1, aramikm, JoeCap08055 and wilwade September 30, 2024 17:19

enddynayn requested a review from demisx as a code owner September 30, 2024 17:36

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 30, 2024

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch from d47f870 to b497605 Compare September 30, 2024 17:37

aramikm reviewed Sep 30, 2024

View reviewed changes

aramikm self-requested a review September 30, 2024 18:13

enddynayn marked this pull request as draft September 30, 2024 18:18

enddynayn added 2 commits September 30, 2024 14:27

chore(node): move genesis to runtime

00e453c

Move the Frequency and Paseo genesis configurations to the runtime. Additionally, refactor the genesis builder for Paseo, Frequency, and Development into a single genesis_builder function.

enddynayn force-pushed the chore/mv-development-genesis-to-runtime-issue-2149 branch from 4b8b5b2 to 00e453c Compare September 30, 2024 19:27

enddynayn added 2 commits September 30, 2024 14:38

changes

0485a2e

update name

2c6e8a2

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 30, 2024

add flag

8840dbc

enddynayn marked this pull request as ready for review September 30, 2024 21:44

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 30, 2024

aramikm approved these changes Sep 30, 2024

View reviewed changes

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 30, 2024

mattheworris approved these changes Sep 30, 2024

View reviewed changes

claireclark1 reviewed Oct 1, 2024

View reviewed changes

JoeCap08055 approved these changes Oct 1, 2024

View reviewed changes

enddynayn merged commit 8e6c002 into main Oct 1, 2024
27 checks passed

enddynayn deleted the chore/mv-development-genesis-to-runtime-issue-2149 branch October 1, 2024 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(genesis): move development genesis config to runtime #2152

chore(genesis): move development genesis config to runtime #2152

enddynayn commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024

JoeCap08055 left a comment

wilwade left a comment

aramikm left a comment

mattheworris left a comment

aramikm left a comment

aramikm left a comment

aramikm Sep 30, 2024

enddynayn Oct 1, 2024

mattheworris left a comment

claireclark1 left a comment

JoeCap08055 left a comment

chore(genesis): move development genesis config to runtime #2152

chore(genesis): move development genesis config to runtime #2152

Conversation

enddynayn commented Sep 5, 2024 • edited Loading

codecov bot commented Sep 5, 2024

Codecov Report

JoeCap08055 left a comment

Choose a reason for hiding this comment

wilwade left a comment

Choose a reason for hiding this comment

aramikm left a comment

Choose a reason for hiding this comment

mattheworris left a comment

Choose a reason for hiding this comment

aramikm left a comment

Choose a reason for hiding this comment

aramikm left a comment

Choose a reason for hiding this comment

aramikm Sep 30, 2024

Choose a reason for hiding this comment

enddynayn Oct 1, 2024

Choose a reason for hiding this comment

mattheworris left a comment

Choose a reason for hiding this comment

claireclark1 left a comment

Choose a reason for hiding this comment

JoeCap08055 left a comment

Choose a reason for hiding this comment

enddynayn commented Sep 5, 2024 •

edited

Loading