feat(msa): add support for unwrapped bytes #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
2 times, most recently
from
98d1bbf
to
d37edb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
wilwade
reviewed
Oct 2, 2024
wilwade
reviewed
Oct 2, 2024
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
2 times, most recently
from
6a15f27
to
93820aa
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
from
4daa4d3
to
b4ec867
Compare
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
from
b4ec867
to
57d132a
Compare
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
from
7f67383
to
93293f7
Compare
enddynayn
requested review from
shannonwells,
mattheworris,
aramikm,
claireolmstead,
saraswatpuneet,
JoeCap08055 and
wilwade
github-actions
bot
added
the
metadata-changed
wilwade
approved these changes
Oct 3, 2024
aramikm
approved these changes
Oct 3, 2024
Comment on lines
+8
to
+13
| if verify_signature(&payload) { | ||
| return true; | ||
| } | ||
|
|
||
| let wrapped_payload = wrap_binary_data(payload); | ||
| verify_signature(&wrapped_payload) |
There was a problem hiding this comment.
nit: I would prefer if we check the wrapped one first as a minor optimization due to most of our signatures are being wrapped.
There was a problem hiding this comment.
nit: I would prefer if we check the wrapped one first as a minor optimization due to most of our signatures are being wrapped.
JoeCap08055
reviewed
Oct 3, 2024
JoeCap08055
reviewed
Oct 3, 2024
JoeCap08055
approved these changes
Oct 3, 2024
Add support to verify signatures against unwrapped bytes. This allows for verification of signatures not using PolkadotUi. issue-2134
enddynayn
force-pushed
the
feat/support-unwrapped-signatures-2134
branch
from
93293f7
to
f4f5d39
Compare
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to verify signatures against unwrapped bytes.
This allows for verification of signatures not using PolkadotUi.
#2134